Rely on @checked in OverflowContexts and reexport
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not see a problem with this change itself. |
|
JuliaHub reports 0 dependents on this or CheckedArithmeticCore, so I guess no real need. There are a couple things in here that I didn't move over... but I guess they just map values to (U)Int128s for "safer" math? Is that functionality useful to keep around? If not, maybe deprecation is in order. Perhaps we can add a note about OverflowContexts to the README at minimum. |
Yes, I agree. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #12, merging some of the functionality of this package with OverflowContexts (https://github.com/JuliaMath/OverflowContexts.jl) is desired, as is using its name. The name is also preferred for that portion, as it would be inclusive of other modes, e.g., saturating math.
OverflowContexts. expanded the
@checkedmacro of this package and expanded it to include other features including@unchecked, allowing these to be arbitrarily nested, and providing the capability to set a default for a module with@default_checkedand@default_uncheckedat the top of a module. It also fixes some limitations with the implementation here.This PR removes the portions that are present in OverflowContexts and adds OverflowContexts as a dependency (starting with newly-registered v0.2.4).
All tests of this package passed with the dependency added and the native macro removed before I removed those specific tests here. For compatibility, CheckedArithmetic will re-exports the portions of OverflowContexts necessary for there to be no break for users of CheckedArithmetic.